Leave it on the charger when you are not using it. The charger will only charge the battery if it needs to be charged; it will not negatively impact battery life.
The only time I would recommend leaving it off the charger is if you don't plan on playing for a long time (like a couple months). If you are not planning on playing for months, it would be a good idea to take the gamepad off the charger and remove the battery.